Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EIP155 signer when needed #350

Merged
merged 1 commit into from
May 23, 2018
Merged

Conversation

tsuzukit
Copy link
Contributor

Fix to #344.
Tested with Web3 1.0.0-beta.34 and networkid and chainid of 10.

Private transaction uses HomesteadSigner as before, but locally signed transaction with Web3 should use EIP155Signer depending on the block number.

networkid and chainid must not be 1, because it will produce V value of 37 which is used to indicate transaction being private with Quorum. (So I think 7nodes example should be fixed too if this is correct fix to the issue)

@jpmsam jpmsam merged commit b6cee6d into Consensys:master May 23, 2018
@peterbroadhurst
Copy link
Contributor

Thanks @jpmsam - we were just looking at this issue, as we came across it when testing MetaMask with Kaleido (per https://kaleido.io/kaleido-meets-metamask/ ). We will look to pull in this fix.

@jpmsam
Copy link
Contributor

jpmsam commented May 23, 2018

@peterbroadhurst thanks to @tsuzukit for his work and contribution.

Szkered pushed a commit to Szkered/quorum that referenced this pull request Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants